Volleyball Elite Academy development update
|
Volleyball Elite Academy
Make the webhook acknowledge cleanup actually re-sync the tab as documented
|
Make the webhook acknowledge cleanup actually re-sync the tab as documentedVolleyball Elite Academy — Development Update • May 12, 2026
--- title: Make the webhook acknowledge cleanup actually re-sync the tab as documented ---
Make the webhook acknowledge cleanup actually re-sync the tab as documented
## What & Why documents that its popstate listener is the mechanism that lets sibling components clean up unrelated query params (specifically the ack-cleanup that strips after auto-acknowledging from the daily email deep-link). However only calls — it never dispatches a event, and on its own does NOT fire one. The popstate listener therefore never actually re-runs after that cleanup, so the documented behavior and the implemented behavior disagree.
Today this happens to be harmless because the ack-cleanup preserves unchanged, so doesn't need to update. But the moment a future ack-cleanup (or any other sibling) needs to change the tab too, it will silently fail.
## Done looks like - After 's ack-cleanup replaceState, URL-aware listeners on the page actually re-run (either by dispatching a event after the replaceState, or by adopting another agreed mechanism). - The misleading comment in near the useEffect is updated to match reality. - A test (extending or the existing webhook-health-banner spec) loads , lets the banner auto-acknowledge, and asserts the URL is cleaned AND the tab listener observed the change.
## Relevant files - (the ack-cleanup useEffect ~lines 231-259, and the popstate useEffect ~lines 1971-1978) - (new test scaffolding to reuse) - (existing webhook-health fixture)
|
Volleyball Elite Academy Reply to this email — we read every reply. You received this because you have an account with Volleyball Elite Academy. elitevolleyball.training |
|
No comments:
Post a Comment